Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
While anything is blocked, the Custom Domains editor in App Select now allows adding websites. Removing them stays locked: there are no delete buttons and no swipe to delete.
If a website is added during a timed unblock of all apps, App Select's existing save (
updateMainSelection) adds it to that unblock, so it is blocked when the unblock ends. This applies to any edit during a timed unblock and isn't new.Tests
testCustomDomainsEditorIsReadOnlyWhileBlockedis nowtestCustomDomainsEditorAddsButDoesNotRemoveWhileBlocked. It starts with onlyexample.comblocked and checks that:example.comcan't be removed;reddit.comcan be added and can't be removed;Results:
NormalUITestsclass on iPhone 17, iOS 27: 11/11.canRemove: true), the new test fails: "Websites can't be removed while blocked".